Re: [PATCH 1/2] [mmotm] Add notifiers for various swap events

From: Nitin Gupta
Date: Mon Dec 28 2009 - 05:21:37 EST


On Mon, Dec 28, 2009 at 11:43 AM, Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> On Mon, Dec 28, 2009 at 3:19 AM, Nitin Gupta <ngupta@xxxxxxxxxx> wrote:
>> Events:
>>  - Swapon
>>  - Swapoff
>>  - When a swap slot is freed

<snip>

> This looks good to me. Hugh? Nitin, does this patch cause any
> performance hit for the !CONFIG_RAMZSWAP case?
>

I have not yet collected any data to check overhead in !RAMZSWAP
case but an empty notifier chain is essentially equivalent to:

rcu_read_lock()
nb = rcu_dereference(*nl);
rcu_read_unlock()

This should not cause any performance problem. Anyway, I will
try to come up with some numbers to confirm this.

Thanks for looking into this.
Nitin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/