Re: [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE

From: Cong Wang
Date: Thu Dec 24 2009 - 21:43:16 EST


Adding some Cc's in the original thread. :)

Amerigo Wang wrote:
BuraphaLinux reported that we will trigger a mm warning when
we CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because
mm cann't allocate so many pages. We should limit the range
of CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user
any chance to trigger that.

Reported-by: BuraphaLinux Server <buraphalinuxserver@xxxxxxxxx>
Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
Cc: David S. Miller <davem@xxxxxxxxxxxxx>

---
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index fc7d9bb..8e8f18d 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig
@@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK
config VGACON_SOFT_SCROLLBACK_SIZE
int "Scrollback Buffer Size (in KB)"
depends on VGACON_SOFT_SCROLLBACK
+ range 1 1024
default "64"
help
Enter the amount of System RAM to allocate for the scrollback

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/