Re: get_maintainers.pl & acer-wmi

[Joe Perches]

On Wed, 2009-12-23 at 21:35 +0000, Carlos Corbacho wrote:
> Hi Joe,

Hi Carlos.

> We're getting some odd results out of get_maintainers.pl for acer-wmi.
> 
> ccorbacho@pacifica:~/src/kernel/linux-2.6$ perl scripts/get_maintainer.pl -f 
> drivers/platform/x86/acer-wmi.c
> 
> Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx>
> John W. Linville <linville@xxxxxxxxxxxxx>
> Len Brown <len.brown@xxxxxxxxx>
> Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>
> Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> linux-kernel@xxxxxxxxxxxxxxx
> 
> Which is odd, as I'm the only maintainer of acer-wmi, so why does it pull in 
> all the other names above?

You have git installed.

get_maintainer.pl by default uses git commit history and searches
for signatures.

These are people that have added "acked-by", "signed-off-by",
"reviewed-by" or any other "by" lines in the git commits.

$ ./scripts/get_maintainer.pl -f drivers/platform/x86/acer-wmi.c
Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx>
John W. Linville <linville@xxxxxxxxxxxxx>
Len Brown <len.brown@xxxxxxxxx>
Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>
Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
linux-kernel@xxxxxxxxxxxxxxx

If you want to not use git history, add --nogit

$ ./scripts/get_maintainer.pl -f --nogit drivers/platform/x86/acer-wmi.c
Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx>
linux-kernel@xxxxxxxxxxxxxxx

With the latest version of get_maintainer, you could add
--rolestats and see how many of the commits were signed
by each person.

$ ./scripts/get_maintainer.pl -f --rolestats drivers/platform/x86/acer-wmi.c
Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx> (maintainer:ACER WMI LAPTOP E...,commit_signer:4/11=36%)
John W. Linville <linville@xxxxxxxxxxxxx> (commit_signer:5/11=45%)
Len Brown <len.brown@xxxxxxxxx> (commit_signer:4/11=36%)
Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx> (commit_signer:3/11=27%)
Johannes Berg <johannes@xxxxxxxxxxxxxxxx> (commit_signer:2/11=18%)
linux-kernel@xxxxxxxxxxxxxxx (open list)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/