Re: [PATCH 2/3] of: make set_node_proc_entry private to proc_devtree.c

From: Grant Likely
Date: Wed Dec 23 2009 - 09:48:49 EST


On Tue, Dec 22, 2009 at 6:45 PM, Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx> wrote:
> We only need set_node_proc_entry in proc_devtree.c, so move it there.
>
> This fixes the !HAVE_ARCH_DEVTREE_FIXUPS build, as we can't make make
> the definition in linux/of.h conditional on this #define (definitions in
> asm/prom.h can't be exposed to linux/of.h, due to the enforced #include
> ordering).
>
> Signed-off-by: Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx>

A little ugly, but it can probably be refactored and cleaned up later
(like a lot of other things in the merged code). Otherwise these
three patches look good to me. I've picked them up into my tree and
I'll push them out soon.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/