Re: [PATCH] prctl: return MCE process flags through pointer

From: Andrew Morton
Date: Tue Dec 22 2009 - 20:34:42 EST


On Wed, 23 Dec 2009 02:14:51 +0100 Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> "Smith, GeoffX" <geoffx.smith@xxxxxxxxx> writes:
>
> > This patch fixes the semantics of prctl() option PR_MCE_KILL_GET
> > to pass the return value through *arg2.
> >
> > With this change, the option now follows the same conventions as the
> > other "get" options added since 2.6.0, and also brings it into
> > conformance with the advice in chapter 16 of Documentation/CodingStyle.
> >
> > This prctl() option was only added within the last month, so there are
> > not any production applications to break. This patch applies cleanly
> > to mainline and to 2.6.32.2 for backporting.
>
> It breaks the test suite, the man pages, qemu and one slide deck at least.
>

Should've got it right the first time.

What goes wrong with qemu?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/