Re: [PATCH] e1000: Fix tests of unsigned in e1000_tx_map()

From: Jeff Kirsher
Date: Tue Dec 22 2009 - 18:50:57 EST


On Tue, Dec 15, 2009 at 11:02, Roel Kluin <roel.kluin@xxxxxxxxx> wrote:
> The variables count and i are unsigned so the (<|>=) 0 tests do not work.
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> This should be all with this pattern.
> As before I wasn't able to test this patch, so please review.
>
> Âdrivers/net/e1000/e1000_main.c | Â 10 +++++-----
> Âdrivers/net/e1000e/netdev.c  Â|  10 +++++-----
> Âdrivers/net/igb/igb_main.c   |  10 +++++-----
> Âdrivers/net/igbvf/netdev.c   |  10 +++++-----
> Âdrivers/net/ixgb/ixgb_main.c  |  10 +++++-----
> Âdrivers/net/ixgbe/ixgbe_main.c | Â 10 +++++-----
> Â6 files changed, 30 insertions(+), 30 deletions(-)
>

Thanks Roel, I will add this patch to my queue. Sorry for the delayed
response, for some odd reason your email got filtered.

--
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/