Re: [PATCH] [1/11] Add rcustring ADT for RCU protected strings

[Paul E. McKenney]

On Tue, Dec 22, 2009 at 11:05:53AM +0100, Andi Kleen wrote:
> On Mon, Dec 21, 2009 at 06:46:35PM -0800, Paul E. McKenney wrote:
> > My guess is that you will sooner or later need a size field, perhaps
> > under some debug config parameter.
> 
> That can be gotten from ksize() if needed.

Fair enough!!!

> > > +/*
> > > + * Get a local private copy of a RCU protected string.
> > > + * Mostly useful to get a string that is stable while sleeping.
> > > + * Caller must free returned string.
> > > + */
> > > +char *access_rcu_string(const char *str, int size, gfp_t gfp)
> > > +{
> > > +	char *copy = kmalloc(size, gfp);
> > > +	if (!str)
> > > +		return NULL;
> > 
> > Assuming that "str" points to the "str" field of a struct rcu_string,
> > what prevents a grace period from elapsing at this point, freeing the
> > "str" out from under us?
> 
> Yes, that's broken thanks. I'll move the reference into the read lock
> section.

Looking forward to seeing the updated version!

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/