Re: [Patch] thinkpad_acpi: fix a build error

[Henrique de Moraes Holschuh]

On Mon, 21 Dec 2009, Randy Dunlap wrote:
> On Mon, 21 Dec 2009 14:38:56 -0800 Marcel Holtmann wrote:
> > > > The patch isn't correct (I guess the upstream fix is same?).
> > > > 
> > > > CONFIG_SOUND is a global config for sound subsystem.  The relevant
> > > > functions are ALSA core part, which is CONFIG_SND.
> > > > So, the fix should be:
> > > > 
> > > > 	depends on SND
> > > > 
> > > > instead.
> > > 
> > > Indeed.  Ingo already fixed that too.
> > > 
> > > Although I personally would prefer:
> > > select SOUND
> > > select SND
> > > 
> > > But anything that stops the build errors will do for now.
> > 
> > I still haven't seen this patch in Linus' tree. And you do need select
> > SOUND and SND. Otherwise you still get build errors. I have tested this
> > on my machine. So can someone please submit a proper patch to get this
> > fixed.
> 
> Ugh.  Please don't 'select' to build an entire subsystem.

I won't in this case. I think I will cook up a patch to disable the entire
mixer subsystem in thinkpad-acpi if CONFIG_SND is not available.  I don't
like the depends on SND though.

As for select an entire subsystem, sorry, but I already do that for stuff
like input and backlight.  Depends is a real CRAP for the user interface in
the case of platform drivers like thinkpad-acpi.

If we could get a depends-no-hide thing, that would not cause drivers to
simply disappear from the config interface without a trace, then maybe I
would have no reason for selects.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/