Re: [PATCHv2 02/12]posix_acl: Add the check items

[Al Viro]

On Tue, Dec 22, 2009 at 10:31:38PM +0800, liu weni wrote:
> Hi All:
> 
>     I'm sorry for my stupid. I am crazy for fixing this bug.
> And make so much mistake.

Welcome to the club.  It's OK, _everyone_ around here had done that.
Many times.

> Maybe I need cool down and think more.
 
Always a good advice, but in this case it's a bit more specific - if you
see that you are modifying behaviour for some arguments, figure out what
would lead to such arguments and see if that behaviour is intentional ;-)
And if after that you are still not sure whether it's a bug or not, ask the
people involved what the hell had they intended to happen in such-and-such
case (often enough that'll bring variants of "nice catch" - bugs *do* happen).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/