Re: BUG null dereference in driver./drivers/usb/misc/sisusbvga/sisusb.c

[Greg KH]

On Mon, Dec 21, 2009 at 08:03:10PM +0000, Alexander Strakh wrote:
>         KERNEL_VERSION: 2.6.32
>         SUBJECT: null derefernce in function sisusb_probe
>         SUBSCRIBE:
>         In driver drivers/usb/misc/sisusbvga/sisusb.c in function 
> sisusb_probe:
> 
> 1. if in line 3085 after calling function kzalloc variable sisub = 
> NULL, then we goto line 3086.
> 2. In line 3086:  null dereference of sisusb - "&sisusb->sisusb_dev->dev".
> 
> 3084         /* Allocate memory for our private */
> 3085         if (!(sisusb = kzalloc(sizeof(*sisusb), GFP_KERNEL))) {
> 3086                 dev_err(&sisusb->sisusb_dev->dev, "Failed to allocate 
> memory for private data\n");
> 3087                 return -ENOMEM;
> 3088         }
> 3089         kref_init(&sisusb->kref);

Good catch, care to send a patch?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/