[patch] rtl8192su: Use z format qualifier for output of sizeof()

From: Simon Horman
Date: Sun Dec 20 2009 - 23:07:57 EST


$ gcc --version
gcc (Debian 4.4.2-5) 4.4.2
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ make
...
drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c: In function âieee80211_rx_ADDBAReqâ:
drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c:342: warning: format â%ldâ expects type âlong intâ, but argument 3 has type âunsigned intâ
drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c: In function âieee80211_rx_ADDBARspâ:
drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c:443: warning: format â%ldâ expects type âlong intâ, but argument 3 has type âunsigned intâ
drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c: In function âieee80211_rx_DELBAâ:
drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c:573: warning: format â%ldâ expects type âlong intâ, but argument 3 has type âunsigned intâ
...

Also some style fixes for these lines:
+ Fix excessively long lines
+ Remove leading space before struct
+ Remove unnecessary parentheses

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Index: linux-2.6/drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c
===================================================================
--- linux-2.6.orig/drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c 2009-12-21 14:52:54.000000000 +1100
+++ linux-2.6/drivers/staging/rtl8192su/ieee80211/rtl819x_BAProc.c 2009-12-21 14:59:53.000000000 +1100
@@ -339,7 +339,10 @@ int ieee80211_rx_ADDBAReq( struct ieee80

if (skb->len < sizeof( struct ieee80211_hdr_3addr) + 9)
{
- IEEE80211_DEBUG(IEEE80211_DL_ERR, " Invalid skb len in BAREQ(%d / %ld)\n", skb->len, (sizeof( struct ieee80211_hdr_3addr) + 9));
+ IEEE80211_DEBUG(IEEE80211_DL_ERR,
+ " Invalid skb len in BAREQ(%d / %zd)\n",
+ skb->len,
+ sizeof(struct ieee80211_hdr_3addr) + 9);
return -1;
}

@@ -440,7 +443,10 @@ int ieee80211_rx_ADDBARsp( struct ieee80

if (skb->len < sizeof( struct ieee80211_hdr_3addr) + 9)
{
- IEEE80211_DEBUG(IEEE80211_DL_ERR, " Invalid skb len in BARSP(%d / %ld)\n", skb->len, (sizeof( struct ieee80211_hdr_3addr) + 9));
+ IEEE80211_DEBUG(IEEE80211_DL_ERR,
+ " Invalid skb len in BARSP(%d / %zd)\n",
+ skb->len,
+ sizeof(struct ieee80211_hdr_3addr) + 9);
return -1;
}
rsp = ( struct ieee80211_hdr_3addr*)skb->data;
@@ -570,7 +576,10 @@ int ieee80211_rx_DELBA(struct ieee80211_

if (skb->len < sizeof( struct ieee80211_hdr_3addr) + 6)
{
- IEEE80211_DEBUG(IEEE80211_DL_ERR, " Invalid skb len in DELBA(%d / %ld)\n", skb->len, (sizeof( struct ieee80211_hdr_3addr) + 6));
+ IEEE80211_DEBUG(IEEE80211_DL_ERR,
+ " Invalid skb len in DELBA(%d / %zd)\n",
+ skb->len,
+ sizeof(struct ieee80211_hdr_3addr) + 6);
return -1;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/