Re: [PATCH] [1/2] SYSCTL: Make bin_table not const

From: Andi Kleen
Date: Sun Dec 20 2009 - 16:07:08 EST


> Is printk_ratelimit truly ineffective at what it does?
>
> Arguably we don't need to warn anywhere near that often, so even
> if printk_ratelimit works we are good.
>
> If printk_ratelimit let's too much through we really should also write
> a patch to let fewer messages through that way.

Any time based rate is too much for compatibility. Assume even if you only
printed one per hour and the user keeps running a program that
uses sysctl it would still be >5000 messages each month.

-Andi
--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/