Re: [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE,LC_NUMERIC to C

[Sam Ravnborg]

On Thu, Dec 17, 2009 at 04:18:35PM +0000, tip-bot for H. Peter Anvin wrote:
> Commit-ID:  c051346b7db27aaf674b8f3b4955240580b2a58a
> Gitweb:     http://git.kernel.org/tip/c051346b7db27aaf674b8f3b4955240580b2a58a
> Author:     H. Peter Anvin <hpa@xxxxxxxxx>
> AuthorDate: Thu, 17 Dec 2009 06:56:11 -0800
> Committer:  H. Peter Anvin <hpa@xxxxxxxxx>
> CommitDate: Thu, 17 Dec 2009 07:03:21 -0800
> 
> Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C
> 
> There are a number of common Unix constructs like character ranges in
> grep/sed/awk which don't work as expected with LC_COLLATE set to other
> than C.  Similarly, set LC_CTYPE and LC_NUMERIC to C to avoid other
> nasty surprises.
> 
> In order to make sure these actually take effect we also have to
> clear LC_ALL.
> 
> Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxx>
> Acked-by: Michal Marek <mmarek@xxxxxxx>
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Acked-by: Roland Dreier <rdreier@xxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> LKML-Reference: <4B2A1761.4070904@xxxxxxx>

This is IMO -next fodder and not urgent stuff.
In the distant past something similar caused us troubles.

I assume that the patch posted by Roland fixes
the relevant troubles with the awk script and that
this patch is just for consistency.
So in other words stuff for -next and not -rc1.

Anyway - just MHO.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/