Re: [PATCH 2/2] perf lock: Fix output of tracing lock events

[Ingo Molnar]

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> >  	TP_STRUCT__entry(
> > +		__field(struct lockdep_map *, lockdep_addr)
> >  		__field(unsigned int, flags)
> >  		__string(name, lock->name)
> >  	),
> 
> I feel a bit awkward explicitly leaking kernel pointers like that. All this 
> is accessible by root only (for now) so its not too harmfull, but sitll.

What would you suggest as a 'natural lock class key'? The name? It might not 
be unique enough.

Other kernel objects like tasks, cpus, inodes, pages all have some natural key 
that isnt a kernel pointer - but locks are a bit special.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/