Re: devtmpfs [censored] oddities

[Greg KH]

On Thu, Dec 17, 2009 at 12:46:43AM +0000, Al Viro wrote:
> On Wed, Dec 16, 2009 at 04:39:22PM -0800, Greg KH wrote:
> > On Wed, Dec 16, 2009 at 08:04:31AM +0000, Al Viro wrote:
> > > 	May I respectfully suggest that a blocking operation (such as
> > > kstrdup with GFP_KERNEL, or grabbing a mutex, or, say it, pathname resolution)
> > > is not quite the thing to do while holding an rwlock?
> > > 
> > > 	As it is, any device_add() is an embarrassingly obvious deadlock
> > > waiting to happen...
> > 
> > Thomas has posted a patch to fix this now.
> > 
> > Sorry for not catching it sooner, we should just delete the rwlocks so
> > no one tries to ever use it again.
> 
> Say again?  Why would we delete rwlocks?

Sorry, no _new_ use of rwlocks should be added, generally they are used
incorrectly, like this one was.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/