Re: devtmpfs [censored] oddities

From: Greg KH
Date: Wed Dec 16 2009 - 19:40:37 EST


On Wed, Dec 16, 2009 at 08:04:31AM +0000, Al Viro wrote:
> May I respectfully suggest that a blocking operation (such as
> kstrdup with GFP_KERNEL, or grabbing a mutex, or, say it, pathname resolution)
> is not quite the thing to do while holding an rwlock?
>
> As it is, any device_add() is an embarrassingly obvious deadlock
> waiting to happen...

Thomas has posted a patch to fix this now.

Sorry for not catching it sooner, we should just delete the rwlocks so
no one tries to ever use it again.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/