Re: [PATCH] regulator: wm831x_reg_read() failure unnoticed inwm831x_aldo_get_mode()

[Liam Girdwood]

On Tue, 2009-12-15 at 20:07 +0100, Roel Kluin wrote:
> ret should be signed to notice a failure in wm831x_reg_read().
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
> 
> diff --git a/drivers/regulator/wm831x-ldo.c b/drivers/regulator/wm831x-ldo.c
> index 902db56..61e02ac 100644
> --- a/drivers/regulator/wm831x-ldo.c
> +++ b/drivers/regulator/wm831x-ldo.c
> @@ -470,7 +470,7 @@ static unsigned int wm831x_aldo_get_mode(struct regulator_dev *rdev)
>  	struct wm831x_ldo *ldo = rdev_get_drvdata(rdev);
>  	struct wm831x *wm831x = ldo->wm831x;
>  	int on_reg = ldo->base + WM831X_LDO_ON_CONTROL;
> -	unsigned int ret;
> +	int ret;
>  
>  	ret = wm831x_reg_read(wm831x, on_reg);
>  	if (ret < 0)

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/