Re: synaptics touchpad doesn't click

From: Takashi Iwai
Date: Wed Dec 16 2009 - 02:11:18 EST


At Tue, 15 Dec 2009 23:03:43 -0800,
Dmitry Torokhov wrote:
>
> On Tue, Dec 15, 2009 at 11:52:00PM -0700, Alex Chiang wrote:
> > * Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>:
> > > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote:
> > > > * Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>:
> > > > >
> > > > > The updated patch is below.
> > > > >
> > > > > --
> > > > > Dmitry
> > > >
> > > > Should I test this one or wait one more iteration to address
> > > > Takashi's last comments?
> > > >
> > >
> > > Actually I think we took the wrong direction with the original patch and
> > > we should do what other buttonless devices (bcm5974) do: report touchpad
> > > click as left button and have Synaptics X driver provide enhanced
> > > support. This way we can have both modes (ClickZones and ClickButtons)
> > > and users will get to chose (provided that someone takes time to add
> > > that support to Synaptics driver of course ;) ).
> > >
> > > Could you tell me if the below works for you?
> >
> > Left clicks work. Right/middle do not (as expected, I guess).
> >
> > I liked the behaviour of Takashi's patch a little better wrt what
> > happens when you try to click/drag, because he disabled movement
> > in the click area.
>
> Are the clicks register only in that special area? Reading Synaptics
> product description it sounds like entire surface should be clickable.

In the case of ClickZone, the click in the button area is taken as
clicks, if I understand correctly.

The problem is, however, not about where to click. It's about the
precision. When you click a pad, your finger slips a little bit in
millimeter. This already corresponds to a few pixels, and the pointer
moves away from the point you wanted to click.

In my original patch, I disabled the pointer movement in the button
area before click for avoiding this problem.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/