Re: [PATCH] thermal: Fix test of unsigned inthermal_cooling_device_cur_state_store()

[Zhang Rui]

On Wed, 2009-12-16 at 05:46 +0800, Roel Kluin wrote:
> state is unsigned long so the test did not work.
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>

Acked-by: Zhang Rui <rui.zhang@xxxxxxxxx>

> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
> 
> Is this the best way to fix this?
> 
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 6f8d8f9..800e0c5 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -374,7 +374,7 @@ thermal_cooling_device_cur_state_store(struct device *dev,
>  	if (!sscanf(buf, "%ld\n", &state))
>  		return -EINVAL;
>  
> -	if (state < 0)
> +	if ((long)state < 0)
>  		return -EINVAL;
>  
>  	result = cdev->ops->set_cur_state(cdev, state);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/