Re: todays git regression (2.6.32-04008.g3ff6a46): lot of devicemapper warnings

[Jens Axboe]

On Tue, Dec 15 2009, Martin K. Petersen wrote:
> >>>>> "Jens" == Jens Axboe <jens.axboe@xxxxxxxxxx> writes:
> 
> Jens> I'll revert the bad commit tomorrow so that -rc1 wont be affected,
> Jens> at least.
> 
> I'm pretty close to having a new stacking algorithm that works.  If I
> don't have it ready by tomorrow maybe we should commit the following
> patch instead of reverting the discard changes wholesale?
> 
> diff --git a/block/blk-settings.c b/block/blk-settings.c
> index dd1f1e0..65ae861 100644
> --- a/block/blk-settings.c
> +++ b/block/blk-settings.c
> @@ -555,10 +555,8 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
>  	}
>  
>  	if (offset &&
> -	    (offset & (b->discard_granularity - 1)) != b->discard_alignment) {
> +	    (offset & (b->discard_granularity - 1)) != b->discard_alignment)
>  		t->discard_misaligned = 1;
> -		ret = -1;
> -	}
>  
>  	/* If top has no alignment offset, inherit from bottom */
>  	if (!t->alignment_offset)

I guess we could do that, as long as it gets really fixed before 2.6.33.
It's a bit ugly to be exporting the device as misaligned, when it's
really just a fudged internally.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/