Re: Warn people about flush_scheduled_work()

[Alan Stern]

On Mon, 14 Dec 2009, Oliver Neukum wrote:

> Am Montag, 14. Dezember 2009 22:33:38 schrieb Alan Stern:
> >         Consider using cancel_work_sync() or cancel_delayed_work_sync()
> >         instead.  In most situations they will accomplish what you 
> >         need.
> 
> In which respect is cancel_work_sync() fundamentally safer?
> If the work is already running and takes a lock you are holding,
> then what?

With cancel_work_sync() you _know_ what locks the work item is going to
take, since it's your work item.  With flush_scheduled_work() you have
no idea what locks will be needed by the items on the queue.  They 
could come from anywhere.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/