Re: [GIT PATCH] TTY patches for 2.6.33-git

From: Linus Torvalds
Date: Sat Dec 12 2009 - 20:15:34 EST




On Sat, 12 Dec 2009, Andrew Morton wrote:

> On Sat, 12 Dec 2009 11:10:32 +0100 Ingo Molnar <mingo@xxxxxxx> wrote:
>
> >
> > * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Seems to be quite .config-dependent.
> >
> > My theory is that it's a race and that it's thus timing dependent. TTY
> > SMP details get stressed most during a particular point during bootup,
> > when all the mingetty's are starting up all at once and race with each
> > other.
> >
> > If you are lucky to not hit the bug then, then the likelyhood is much
> > lower later on.
> >
> > It would be nice if Alan posted his TTY stress-testing code. It could
> > potentially make this bug bisectable.
> >
>
> I'm surprised that lockdep didn't notice that ab/ba I thought I saw.
> Maybe the do_tty_hangup()->tty_fasync() never happens.

The kernel lock cannot have any ABBA deadlocks.

If somebody blocks on another lock (after getting the kernel lock), the
kernel lock will be dropped. So no ABBA.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/