Re: [PATCH 1/4] ftrace: Fix MATCH_END_ONLY filter matching
From: Frederic Riss
Date: Fri Dec 11 2009 - 07:20:31 EST
2009/12/11 Li Zefan <lizf@xxxxxxxxxxxxxx>:
> For '*foo' pattern, we should allow any string ending with
> 'foo', but ftrace filter incorrectly disallows strings
> like bar_foo_foo:
[...]
> case MATCH_END_ONLY:
> - ptr = strstr(str, regex);
> - if (ptr && (ptr[len] == 0))
> + slen = strlen(str);
> + if (slen >= len && memcpy(str + slen - len, regex, len))
> matched = 1;
Shouldn't that be memcmp() == 0? I don't see how memcpy might serve as
a compare operator.
Fred.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/