* H. Peter Anvin<hpa@xxxxxxxxx> wrote:
On 12/02/2009 02:09 AM, Ingo Molnar wrote:
* Xiaotian Feng<dfeng@xxxxxxxxxx> wrote:
pci_get_device increments reference count to the found pci device,
that should be decremented using pci_dev_put.
+++ b/arch/x86/kernel/reboot_fixups_32.c
@@ -80,6 +80,7 @@ void mach_reboot_fixups(void)
continue;
cur->reboot_fixup(dev);
+ pci_dev_put(dev);
Does this matter in practice? We are about to reboot. (but if it's
cleaner to do it like this or if there's some real bug fixed by this
then please spell it out in the changelog.)
Even if it doesn't actually matter, doing things cleanly makes it
easier to handle failure scenarios, possibly that are discovered in
the future.
certainly - but it would be nice to know whether there's any other
reason for this but cleanliness/consistency.
Ingo