Re: [PATCH 06/24] HWPOISON: abort on failed unmap
From: Wu Fengguang
Date: Wed Dec 02 2009 - 08:29:06 EST
On Wed, Dec 02, 2009 at 09:11:50PM +0800, Andi Kleen wrote:
> > * Now take care of user space mappings.
> > + * Abort on fail: __remove_from_page_cache() assumes unmapped page.
> > */
> > - hwpoison_user_mappings(p, pfn, trapno);
> > + if (hwpoison_user_mappings(p, pfn, trapno) != SWAP_SUCCESS) {
> > + res = -EBUSY;
> > + goto out;
>
> It would be good to print something in this case.
OK.
> Did you actually see it during testing?
Perhaps not.
> Or maybe loop forever in the unmapper.
!SWAP_SUCCESS should be rare, so not necessary to loop forever?
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/