On Mon, 2009-11-30 at 05:36 -0500, William Allen Simpson wrote:Then why make an *un*important (yet sweeping) change?Over the past several days, David Miller (with help from Joe Perches)
made sweeping changes to the format of conditional statements in the
net tree -- the equivalent of mass patches that change spaces.
This makes writing patches for multiple versions of the tree very
difficult, and will make future pullups problematic.
If it makes getting tcp cookies accepted difficult,
a reversion is simple. That style isn't as important.
I think writing a single set of patches for multipleMy patches were carefully written and applied with small fuzz to .30,
versions of linux is not feasible. Feature changes
occur in kernel source daily.
That seems fine to me. And in some areas of the tree, nearly 100% ofif (condition
&& condition
&& (condition
|| condition
|| condition)) {
The above is my personally preferred style.
That's only true in net/ -- since the overall tree was 18.7%, withif (condition &&
condition && (condition || condition ||
condition)) {
Except for the odd spacing, this is the significant
majority of net/ style.
The leading style was < 10%. It's less now.