Re: [PATCH 1/2] pci: release that leaf bridge' resource that is notbig -v11

[Kenji Kaneshige]

Yinghai Lu wrote:
> Kenji Kaneshige wrote:
> > Hi,
> >
> > I tried v11 patches. This version seems to fix the problem I
> > reported against previous version.
> >
> > I have no objection against the idea of resource allocation
> > changes for PCI express hotplug slots.
>
> thanks
>
> > But I still have concern about changing resource allocation for
> > other than PCI express hotplug slots. For example, some hotplug
> > controller other than PCI express can have multiple slots under
> > the same bus. If some hotplug slots are occupied and the others
> > are empty at the boot time, I think your code try to shrink the
> > bus resources for hotplug slots allocated by BIOS. It would break
> > the hot-add on the empty slots due to the resource allocation
> > failure.
>
> no,
> it will not touch bridge resources that already assigned by BIOS except
> some bridge resource is not big enough. and get big one for them.

Ok, I understood that if the BIOS assigns enough resources to the
bridge, it has no impact.

One question. I thought your patch shrinks the bridge resource to
allocate enough resource for sibling bridge. But it actually doesn't.
Right?

It would be appreciated if you update the patch description about
the problem and how to fix/improbe it.

Thanks,
Kenji Kaneshige

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/