Re: [PATCH] mtd: fix mtd_blkdevs problem with caches on somearchitectures (2.6.31)

[Andrew Morton]

On Sun, 22 Nov 2009 02:11:28 +0300 Ilya Loginov <isloginov@xxxxxxxxx> wrote:

> I think we should select SYS_HAS_FLUSH_DCACHE_PAGE for those
> architectures which requires it(to fix the bug) (and implement empty
> flush_dcache_page throught inline like in x86(to avoid pointless do
> {} while(0))).
> 
> What do you think about this?

Well, rather that defining CONFIG_SYS_HAS_FLUSH_DCACHE_PAGE in
Kconfig (which is what I think your were thinking of), we could do:

--- a/arch/x86/include/asm/cacheflush.h~a
+++ a/arch/x86/include/asm/cacheflush.h
@@ -13,6 +13,7 @@ static inline void flush_cache_range(str
 static inline void flush_cache_page(struct vm_area_struct *vma,
 				    unsigned long vmaddr, unsigned long pfn) { }
 static inline void flush_dcache_page(struct page *page) { }
+#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0
 static inline void flush_dcache_mmap_lock(struct address_space *mapping) { }
 static inline void flush_dcache_mmap_unlock(struct address_space *mapping) { }
 static inline void flush_icache_range(unsigned long start,
--- a/arch/arm/include/asm/cacheflush.h~a
+++ a/arch/arm/include/asm/cacheflush.h
@@ -409,6 +409,7 @@ extern void flush_ptrace_access(struct v
  * See update_mmu_cache for the user space part.
  */
 extern void flush_dcache_page(struct page *);
+#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1
 
 extern void __flush_dcache_page(struct address_space *mapping, struct page *page);
 
(etc)

And then, in a .c file:

#ifndef ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
#error "you lose"
#endif

and, of course:

#if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
<implement real code>
#else
<implement empty stubs>
#endif


This way

a) the definition site for ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE is
   right next to the definition site for flush_dcache_page(), instead
   of being in some random remote file and

b) people can't forget to implement ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE.


Generally we prefer to avoid defining ARCH_HAS_FOO in header files and
we prefer to control the definition in Kconfig.  But it sounds like we
have a special case here..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/