Re: [patch 06/13] powerpc: Fixup last users of irq_chip->typename

From: Grant Likely
Date: Sat Nov 21 2009 - 03:09:52 EST


On Wed, Nov 18, 2009 at 1:41 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Wed, 18 Nov 2009, Scott Wood wrote:
>> On Tue, Nov 17, 2009 at 10:50:53PM +0000, Thomas Gleixner wrote:
>> > Index: linux-2.6/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
>> > ===================================================================
>> > --- linux-2.6.orig/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
>> > +++ linux-2.6/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
>> > @@ -69,7 +69,7 @@ static void pq2ads_pci_unmask_irq(unsign
>> >  }
>> >
>> >  static struct irq_chip pq2ads_pci_ic = {
>> > -   .typename = "PQ2 ADS PCI",
>> > +   .name = "PQ2 ADS PCI",
>> >     .name = "PQ2 ADS PCI",
>> >     .end = pq2ads_pci_unmask_irq,
>> >     .mask = pq2ads_pci_mask_irq,
>>
>> Duplicate ".name"...
>
> Darn.

Other than that, looks good to me.

Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/