[PATCH] net: ETHOC should depend on HAS_DMA (was: Re: [PATCH] ETHOC: fix build breakage on s390)

[Geert Uytterhoeven]

On Mon, Mar 30, 2009 at 10:30, Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:
> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> Let driver depend on HAS_IOMEM to avoid build breakage on s390:
>
> ÂCC Â Â Âdrivers/net/ethoc.o
> drivers/net/ethoc.c: In function 'ethoc_read':
> drivers/net/ethoc.c:221: error: implicit declaration of function 'ioread32'
> drivers/net/ethoc.c: In function 'ethoc_write':
> drivers/net/ethoc.c:226: error: implicit declaration of function 'iowrite32'
> drivers/net/ethoc.c: In function 'ethoc_rx':
> drivers/net/ethoc.c:405: error: implicit declaration of function 'memcpy_fromio'
> drivers/net/ethoc.c: In function 'ethoc_start_xmit':
> drivers/net/ethoc.c:828: error: implicit declaration of function 'memcpy_toio'
>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> ---
> Âdrivers/net/Kconfig | Â Â2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/net/Kconfig
> ===================================================================
> --- linux-2.6.orig/drivers/net/Kconfig
> +++ linux-2.6/drivers/net/Kconfig
> @@ -974,7 +974,7 @@ config ENC28J60_WRITEVERIFY
>
> Âconfig ETHOC
> Â Â Â Âtristate "OpenCores 10/100 Mbps Ethernet MAC support"
> - Â Â Â depends on NET_ETHERNET
> + Â Â Â depends on NET_ETHERNET && HAS_IOMEM

This is not sufficient, it has to depend on HAS_DMA, too: