Re: [tip:irq/core] genirq: switch /proc/irq/*/spurious to seq_file

From: Alexey Dobriyan
Date: Thu Nov 19 2009 - 13:52:33 EST


On Wed, Nov 18, 2009 at 11:54:34AM +0000, tip-bot for Alexey Dobriyan wrote:
> --- a/kernel/irq/proc.c
> +++ b/kernel/irq/proc.c
> @@ -148,18 +148,28 @@ static const struct file_operations default_affinity_proc_fops = {
> };
> #endif
>
> -static int irq_spurious_read(char *page, char **start, off_t off,
> - int count, int *eof, void *data)
> +static int irq_spurious_proc_show(struct seq_file *m, void *v)
> {
> - struct irq_desc *desc = irq_to_desc((long) data);
> - return sprintf(page, "count %u\n"
> - "unhandled %u\n"
> - "last_unhandled %u ms\n",
> - desc->irq_count,
> - desc->irqs_unhandled,
> - jiffies_to_msecs(desc->last_unhandled));
> + struct irq_desc *desc = irq_to_desc((long) m->private);
^^^^^^^^^^
> +
> + seq_printf(m, "count %u\n" "unhandled %u\n" "last_unhandled %u ms\n",
> + desc->irq_count, desc->irqs_unhandled,
> + jiffies_to_msecs(desc->last_unhandled));
> + return 0;
> +}
> +
> +static int irq_spurious_proc_open(struct inode *inode, struct file *file)
> +{
> + return single_open(file, irq_spurious_proc_show, NULL);

Oops, there has to be PDE(inode)->data instead of NULL.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/