Re: [PATCH 3/4] perf symbols: Record the build_ids of kernel modules too

[Roland McGrath]

> +		snprintf(name, sizeof(name),
> +			 "/sys/module/%s/notes/.note.gnu.build-id", line);

The arch linker script for .ko's is free to fold notes into a single
section with a different name or suchlike, and maybe future ones will.  So
it's not pedantically kosher to assume the name of the section rather than
just looking at all the /sys/module/%s/notes/* files present until you find
NT_GNU_BUILD_ID.  (In practice there is probably only ever one file there
to look at, but you never know.)


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/