Re: [PATCH 1/1] Add all TWL4030 regulators to Regulator framework

[Dmitry Torokhov]

On Wed, Nov 18, 2009 at 01:46:35PM +0200, Juha Keski-Saari wrote:
> This patch adds all the remaining TWL4030 regulators into the implementation,
> also adding VINT* regulators in this way since they can be derived out from
> the TWL
>
> Signed-off-by: Juha Keski-Saari <ext-juha.1.keski-saari@xxxxxxxxx>
> ---
>  drivers/mfd/twl4030-core.c            |   30 ++++++++++++++++++++++++++----
>  drivers/regulator/twl4030-regulator.c |   27 +++++++++++++++++----------
>  include/linux/i2c/twl4030.h           |    8 ++++++--
>  3 files changed, 49 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index a1c47ee..0748b43 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -602,13 +602,15 @@ add_children(struct twl4030_platform_data *pdata, unsigned long features)
>  	}
>
>  	if (twl_has_regulator()) {
> -		/*
> -		child = add_regulator(TWL4030_REG_VPLL1, pdata->vpll1);
> +		child = add_regulator(TWL4030_REG_VDD1, pdata->vdd1);
>  		if (IS_ERR(child))
>  			return PTR_ERR(child);
> -		*/
>
> -		child = add_regulator(TWL4030_REG_VMMC1, pdata->vmmc1);
> +		child = add_regulator(TWL4030_REG_VDD2, pdata->vdd2);
> +		if (IS_ERR(child))
> +			return PTR_ERR(child);
> +
> +		child = add_regulator(TWL4030_REG_VIO, pdata->vio);
>  		if (IS_ERR(child))
>  			return PTR_ERR(child);

Not specifically targeted at this patch - this driver error handling is
severely lacking and leaves bund of devices behind when one of them
fails to be added.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/