Re: [PATCH 1/1] Add all TWL4030 regulators to Regulator framework

[Eduardo Valentin]

On Wed, Nov 18, 2009 at 02:39:39PM +0100, Mark Brown wrote:
> On Wed, Nov 18, 2009 at 01:46:35PM +0200, Juha Keski-Saari wrote:
> > This patch adds all the remaining TWL4030 regulators into the implementation,
> > also adding VINT* regulators in this way since they can be derived out from
> > the TWL
> > 
> > Signed-off-by: Juha Keski-Saari <ext-juha.1.keski-saari@xxxxxxxxx>
> 
> This is fine from an API point of view but I worry that if any of the
> boards are using regulator_has_full_constraints() then this will break
> them by causing them to be powered off at the end of init.  Have you
> checked the in-tree twl4030 users for this?

Looks like no one is using the regulator_has_full_constraints(). At least the twl4030 users.

But maybe these VINT* should be set as always_on in twl4030-regulator driver?

-- 
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/