[PATCH] mtd: fix mtd_blkdevs problem with caches on somearchitectures (2.6.31)

From: Ilya Loginov
Date: Wed Nov 18 2009 - 09:03:42 EST


Mtdblock driver doesn't call flush_dcache_page for pages in request.
This may cause problem on architectures where icache doesn't fill from
dcache or with dcache aliases.
This patch resolves this issue.

Signed-off-by: Ilya Loginov <isloginov@xxxxxxxxx>
---
mtd_blkdevs.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 7baba40..59d5d25 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -46,6 +46,8 @@ static int do_blktrans_request(struct mtd_blktrans_ops *tr,
{
unsigned long block, nsect;
char *buf;
+ struct req_iterator iter;
+ struct bio_vec *bvec;

block = blk_rq_pos(req) << 9 >> tr->blkshift;
nsect = blk_rq_cur_bytes(req) >> tr->blkshift;
@@ -68,12 +70,17 @@ static int do_blktrans_request(struct mtd_blktrans_ops *tr,
for (; nsect > 0; nsect--, block++, buf += tr->blksize)
if (tr->readsect(dev, block, buf))
return -EIO;
+ rq_for_each_segment(bvec, req, iter)
+ flush_dcache_page(bvec->bv_page);
return 0;

case WRITE:
if (!tr->writesect)
return -EIO;

+ rq_for_each_segment(bvec, req, iter)
+ flush_dcache_page(bvec->bv_page);
+
for (; nsect > 0; nsect--, block++, buf += tr->blksize)
if (tr->writesect(dev, block, buf))
return -EIO;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/