Re: [PATCH -tip 0/3] tracepoint: Add signal events

[Roland McGrath]

I would add the siginfo_t * argument to each of these tracepoints.

In 2/3 this comment:

+		/* Trace the actual delivered signals including SIG_IGN.*/

might be slightly misleading.  In most cases SIG_IGN signals won't make it
this far.  The same is true of SIG_DFL signals whose default action is to
ignore.  So one should be clear that trace_signal_deliver() is by no means
expected to get all SIG_IGN signals that are otherwise eligible for delivery.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/