Re: [PATCH 3/6] INIT: Limit the number of per cpu calibrationbootup messages

From: David Miller
Date: Tue Nov 17 2009 - 11:29:25 EST


From: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
Date: Tue, 17 Nov 2009 18:59:46 +0300

> Perhaps for other archs like SPARC64, where as you said no need to
> remember boot cpu id at all, we should define some __weak per-kernel
> global helper which would return 0 and every arch would implement
> own helper boot_cpu_id().

On many of my machines none of my cpus are numbered "0", so that
wouldn't be a legitimate implementation on sparc64.

I see no reason for a platform the be required to remember the boot
cpu ID, there is nothing special about that processor generically.

And if we do need it generically, it's available there as
hard_smp_processor_id() when start_kernel() is called. So init/main.c
could remember that value in an __initdata annotated static variable.

But just using a boolean for this "did I print the bogomips message
already?" thing seems more than sufficient.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/