Re: [PATCH 3/4] powerpc: Only define smp_pSeries_cpu_bootable whenCONFIG_XICS is set

From: Michael Ellerman
Date: Tue Nov 17 2009 - 07:47:12 EST


On Tue, 2009-11-17 at 12:07 +0000, Mel Gorman wrote:
> If CONFIG_XICS is set, then smp_pSeries_cpu_bootable() is unnecessary.
> As warnings are treated as errors, this fails to build.
>
> This patch only defines smp_pSeries_cpu_bootable() when CONFIG_XICS is
> set.

I'm not sure, but I would guess that was just an oversight by whoever
added the cpu_bootable check. By which I mean it should be in the mpic
ops as well - avoiding the need for any ifdefery.

cheers

Attachment: signature.asc
Description: This is a digitally signed message part