Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to

[Eric W. Biederman]

Alexey Dobriyan <adobriyan@xxxxxxxxx> writes:

>> -		.proc_handler	= proc_dointvec
>> +		.proc_handler	= &proc_dointvec,
>
> NAK.
>
> commit 6d9f239a1edb31d6133230f478fd1dc2da338ec5
> Author: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> Date:   Mon Nov 3 18:21:05 2008 -0800
>
>     net: '&' redux
>     
>     I want to compile out proc_* and sysctl_* handlers totally and
>     stub them to NULL depending on config options, however usage of &
>     will prevent this, since taking adress of NULL pointer will break
>     compilation.

I just experimented with this and found that at present a number of
the proc handlers wrap functions like proc_dointvec, so it does not work.

Did you have a plan for those?

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/