Re: [PATCH v2 00/10] LIS3: Feature updates and corrections

From: Andrew Morton
Date: Mon Nov 16 2009 - 15:04:45 EST


On Sun, 15 Nov 2009 17:01:34 +0100
__ric Piel <eric.piel@xxxxxxxxxxxxxxxx> wrote:

> Op 10-11-09 13:41, Samu Onkalo schreef:
> > This patch set has earlier been sent to lm-sensors list (thus patch v2).
> > No changes after that except to patch 0006 to make it applicable to
> > 2.6.32-rc6 (no functional changes).
> :
> >
> > I have possibility to test these changes only with 8 bit version (lis302d).
> > Since part of the changes are specific to 12 bit device, I would appreciate
> > if someone could try these on 12 bit device.
> I've just tested them on a 12-bit device and it seems to go fine
> (excepted the rate setting in patch 8).
>
> Andrew, maybe you could already queue the first 5 patches, as they all
> look fine and are fixing bugs. So we are sure they are there for 2.6.33
> :-) The rest of the patch series is useful but just "new feature" and
> some need more work.

OK, I merged the five.

We could sneak some/all of them into 2.6.32 I guess, if you think
that's warranted?

The ones which were From:yourself were missing Samu's Signed-off-by:.
I added it.

"[PATCH v2 04/10] lis3: fix show rate for 8 bits chips" has a poor
changelog. "fix with 8 bits sensors". It failed to tell us what the
bug was, what its user-visible effects were, how it was fixed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/