Re: [PATCH] Input: fix wrong synaptics detection inpsmouse_extensions()

[Jiri Kosina]

[ fixed linux-input CC which I have typoed previously ]

On Mon, 16 Nov 2009, Dmitry Torokhov wrote:

> On Mon, Nov 16, 2009 at 12:51:30PM +0100, Jiri Kosina wrote:
> > Commit b7802c5c1ea ("Input: psmouse - use boolean type") caused the 
> > synaptics_hardware variable to be completely useless, as it is constantly 
> > set to 'true' throughout the whole psmouse_extensions(). This was caused 
> > by the following hunk in the commit in question
> > 
> > 	-       int synaptics_hardware = 0;
> > 	+       bool synaptics_hardware = true;
> > 
> > which is wrong. Fix that up.
> 
> Hmm, not sure what I was thinnking at that time but it is obviously I
> should have stayed away form tehe keyboard...
> 
> Applied, thank you Jiri.

I guess you will be pushing that one to .32 still, right? I think it's 
quite crucial fix, so if it doesn't make it in time for .32 (I am not sure 
whether Linus will be doing next -rc or not), it should go to -stable for 
.32 right away.

Thanks!

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/