Re: [PATCH]: AMD Northbridge: Verify NB's node is online

[Prarit Bhargava]

> > Hardware maybe programmed incorrectly and return a bogus node ID.  
> > Check to see if the node is actually online before setting the numa 
> > node for an AMD northbridge in quirk_amd_nb_node().
> >     
>
> Hm, could you stick a printk in there, what precise node ID does the 
> hardware return?
>
>   

Ingo, yup -- I put in a printk and commented out the set_dev_node() call 
when debugging this
and got this output:

quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x0
quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x1
quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x2
quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x3

The issue appears to be that the HW has set val to a valid value, 
however, the system is only configured for a single node -- 0.

I realize that I'm working around broken HW ... but I think that a 
quirk, quirk_amd_nb_node(), should at least keep systems booting ...

P.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/