Re: [ RFC, PATCH - 1/2, v2 ] x86-microcode: refactor microcodeoutput messages

[Andreas Herrmann]

The patches don't properly work here.

(1) For instance I got following log entries when doing
    suspend/resume, doing CPU offline/online test and reloading the
    module:

  microcode: original microcode versions...
  microcode: CPU0-3: patch_level=0x1000065


  platform microcode: firmware: requesting amd-ucode/microcode_amd.bin
  ...
  microcode: CPU0-1,3: patch_level=0x1000083

  microcode: CPU2-3: patch_level=0x1000065

  Microcode Update Driver: v2.00 <tigran@xxxxxxxxxxxxxxxxxxxx>, Peter Oruba

The patch levels are:

  # for i in `seq 0 3`; do lsmsr -c $i PATCH_LEVEL; done
  PATCH_LEVEL          = 0x0000000001000083
  PATCH_LEVEL          = 0x0000000001000083
  PATCH_LEVEL          = 0x0000000001000065
  PATCH_LEVEL          = 0x0000000001000065

(2) During suspend/resume the ucode is not updated:

  hadburg linux # for i in `seq 0 3`; do lsmsr -c $i PATCH_LEVEL; done
  PATCH_LEVEL          = 0x0000000001000083
  PATCH_LEVEL          = 0x0000000001000083
  PATCH_LEVEL          = 0x0000000001000083
  PATCH_LEVEL          = 0x0000000001000083
  hadburg linux # pm-suspend
  hadburg linux # for i in `seq 0 3`; do lsmsr -c $i PATCH_LEVEL; done
  PATCH_LEVEL          = 0x0000000001000065
  PATCH_LEVEL          = 0x0000000001000065
  PATCH_LEVEL          = 0x0000000001000065
  PATCH_LEVEL          = 0x0000000001000065


That used to work w/o your patches. Didn't have time to look why this
is now failing. You've changed mc_cpu_callback() -- most likely that
is causing this regression.


Regards,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/