Re: [RFC][PATCH] Add prctl to set sibling thread names

From: Darren Hart
Date: Thu Nov 05 2009 - 00:37:03 EST


KOSAKI Motohiro wrote:
KOSAKI Motohiro wrote:

John, I'd prefer to suggested another design.
How about this?

1. remove pid argument from prctl
2. cancel pthread_setname_np()
3. instead, create pthread_attr_setname_np()
4. pthread_create() change own thread name by pthread_attr.

It avoid many racy problem automatically.
Perhaps, but it also greatly reduces the flexibility of the implementation by restricting name changes to create time.

Hm.
if your program really need to change another thread name, can you please tell us
why it is necessary and when it is used?


I think John's previous mails covered that pretty well. As for doing the name change at create time, or sometime later, it just seems to me that the flexibility of doing so later is worth having. While I know we don't have to follow other systems implementations, in this case pthread_setname_np() seems a reasonable model to follow to me.

--
Darren Hart
IBM Linux Technology Center
Real-Time Linux Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/