Re: [PATCH 2/3] ftrace: Return EINVAL when writing invalid val toset_ftrace_filter

From: Frederic Weisbecker
Date: Tue Nov 03 2009 - 20:44:44 EST


On Tue, Nov 03, 2009 at 08:56:28AM +0800, Li Zefan wrote:
> Currently it doesn't warn user on invald value:
>
> # echo nonexist_symbol > set_ftrace_filter
>
> Better make it return failure.
>
> Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
> ---


Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

But shouldn't we have the same kind of check from
ftrace_match_module_records() if we haven't matched
anything with the regex?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/