Re: [PATCH v2 3/7] Adding general performance benchmarkingsubcommand to perf.

[Ingo Molnar]

* Hitoshi Mitake <mitake@xxxxxxxxxxxxxxxxxxxxx> wrote:

> 
> Adding general performance benchmarking subcommand to perf.
> This patch adds bench/sched-pipe.c.
> 
> bench/sched-pipe.c is a benchmark program
> to measure performance of pipe() system call.
> This benchmark is based on pipe-test-1m.c by Ingo Molnar.
> http://people.redhat.com/mingo/cfs-scheduler/tools/pipe-test-1m.c
> 
> Example of use:
> % perf bench sched pipe               # Use default options
> 4.575  	     	   		      # Result is time
> % perf bench sched pipe -l 2000	      # This option means "loop 2000 counts"
> 0.024

ok, -l makes sense.

Shouldnt we output the unit of measurement, i.e. '4.575 usecs'? Also, we 
should perhaps print something like:

  % perf bench sched pipe

  (executing 1000000 pipe operations between two tasks)

     4.575 usecs per op
    218579 ops/sec   

?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/