Re: [PATCH 1/1] perf probe: Annotate variable initialization

From: Masami Hiramatsu
Date: Tue Nov 03 2009 - 10:46:56 EST


Arnaldo Carvalho de Melo wrote:
From: Arnaldo Carvalho de Melo<acme@xxxxxxxxxx>

cc1: warnings being treated as errors
builtin-probe.c: In function âparse_probe_eventâ:
builtin-probe.c:72: warning: âncâ is used uninitialized in this function

Cc: Masami Hiramatsu<mhiramat@xxxxxxxxxx>
Signed-off-by: Arnaldo Carvalho de Melo<acme@xxxxxxxxxx>

Oops, thank you!

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

---
tools/perf/builtin-probe.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index a99a366..8124523 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -69,7 +69,7 @@ static struct {
static void parse_probe_point(char *arg, struct probe_point *pp)
{
char *ptr, *tmp;
- char c, nc;
+ char c, nc = 0;
/*
*<Syntax>
* perf probe SRC:LN

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/