Re: [PATCH] perf tools: add compatibility with libelf 0.8 and autodetect

From: Marti Raudsepp
Date: Fri Oct 23 2009 - 21:19:32 EST


On Sat, Oct 24, 2009 at 4:07 AM, Lucas De Marchi
<lucas.de.marchi@xxxxxxxxx> wrote:
> Why don't you do something like?:
>
> #ifdef LIBELF_NO_MMAP
> #define ELF_C_READ_MMAP ELF_C_READ
> #endif

Seemed like bad programming practice to redefine enum constants from
third-party include files. But you are right, it would significantly
simplify the patch. Can we get a third opinion?

Marti
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/