Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops

From: Bjorn Helgaas
Date: Fri Oct 23 2009 - 17:43:30 EST


On Friday 23 October 2009 01:11:48 pm Ike Panhc wrote:

> +static int __init lenovo_sl_laptop_init(void)
> +{
> + int ret;
> + acpi_status status;
> +
> + if (acpi_disabled)
> + return -ENODEV;

Don't need this.

> + lenovo_sl_laptop_hkey_handle = lenovo_sl_laptop_ec0_handle = NULL;
> + status = acpi_get_handle(NULL, ACPI_HKEY_PATH,
> + &lenovo_sl_laptop_hkey_handle);
> + if (ACPI_FAILURE(status)) {
> + pr_err("Failed to get ACPI handle for %s\n", ACPI_HKEY_PATH);
> + return -ENODEV;
> + }

Don't need this; acpi_bus_register_driver() is enough.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/