Re: [RFC/PATCH] ratelimit: make output more useful

From: Ingo Molnar
Date: Fri Oct 23 2009 - 10:55:23 EST



* Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote:

> Index: tip/include/linux/kernel.h
> ===================================================================
> --- tip.orig/include/linux/kernel.h
> +++ tip/include/linux/kernel.h
> @@ -16,6 +16,7 @@
> #include <linux/log2.h>
> #include <linux/typecheck.h>
> #include <linux/dynamic_debug.h>
> +#include <linux/ratelimit.h>
> #include <asm/byteorder.h>
> #include <asm/bug.h>
>

hm, this will cause circular dependencies - see:

3fff4c4: printk: Remove ratelimit.h from kernel.h

Any reason why it couldnt be pushed inside printk.c? We just need the
func string - not the pointer pass-in. That would also address some of
the call-site bloat.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/